Show data agent review summaries in sessions
This commit is contained in:
武阳
+107
-7
@@ -274,29 +274,29 @@ class AgentRuntimeTests(unittest.TestCase):
|
||||
self.assertGreaterEqual(len(result.transcript), 5)
|
||||
self.assertGreaterEqual(len(result.file_history), 0)
|
||||
|
||||
def test_agent_stops_after_data_agent_plan_requires_review(self) -> None:
|
||||
def test_agent_stops_after_data_agent_goal_requires_review(self) -> None:
|
||||
responses = [
|
||||
{
|
||||
'choices': [
|
||||
{
|
||||
'message': {
|
||||
'role': 'assistant',
|
||||
'content': 'I will prepare a reviewable plan.',
|
||||
'content': 'I will prepare a reviewable generation goal.',
|
||||
'tool_calls': [
|
||||
{
|
||||
'id': 'call_1',
|
||||
'type': 'function',
|
||||
'function': {
|
||||
'name': 'data_agent_prepare_generation_plan',
|
||||
'name': 'data_agent_prepare_generation_goal',
|
||||
'arguments': json.dumps(
|
||||
{
|
||||
'dataset_label': '地图和生活边界数据',
|
||||
'goal_summary': '生成附近生活服务边界数据',
|
||||
'target': 'Agent(tag="life_service")',
|
||||
'total_count': 2,
|
||||
'turn_mix': '1 条单轮，1 条多轮',
|
||||
'plan_hint': '建议先生成 10 条单轮，输出到 tasks/demo/records.jsonl；具体数量、轮次和路径在 generation plan 中确认。',
|
||||
'coverage': '附近吃喝玩乐',
|
||||
'exclusions': '不要生成导航路线类 query',
|
||||
'output_path': 'tasks/demo/artifacts',
|
||||
'source_refs': ['manual:user'],
|
||||
}
|
||||
),
|
||||
},
|
||||
@@ -318,14 +318,114 @@ class AgentRuntimeTests(unittest.TestCase):
|
||||
),
|
||||
runtime_config=AgentRuntimeConfig(cwd=workspace),
|
||||
)
|
||||
result = agent.run('Prepare data generation plan')
|
||||
result = agent.run('Prepare data generation goal')
|
||||
|
||||
self.assertEqual(result.stop_reason, 'user_review_required')
|
||||
self.assertEqual(result.tool_calls, 1)
|
||||
self.assertIn('本轮已暂停', result.final_output)
|
||||
self.assertIn('goal_id', result.final_output)
|
||||
self.assertIn('计划提示', result.final_output)
|
||||
self.assertIn('建议先生成 10 条单轮', result.final_output)
|
||||
review_messages = [
|
||||
entry
|
||||
for entry in result.transcript
|
||||
if entry.get('role') == 'assistant'
|
||||
and entry.get('stop_reason') == 'user_review_required'
|
||||
]
|
||||
self.assertEqual(len(review_messages), 1)
|
||||
self.assertIn('数据生成目标', str(review_messages[0].get('content', '')))
|
||||
self.assertTrue(
|
||||
any(event.get('type') == 'user_review_required' for event in result.events)
|
||||
)
|
||||
self.assertTrue(
|
||||
any(
|
||||
event.get('type') == 'user_review_required'
|
||||
and isinstance(event.get('review_message_id'), str)
|
||||
for event in result.events
|
||||
)
|
||||
)
|
||||
|
||||
def test_agent_appends_review_message_after_data_agent_plan_requires_review(self) -> None:
|
||||
with tempfile.TemporaryDirectory() as tmp_dir:
|
||||
workspace = Path(tmp_dir)
|
||||
context = build_tool_context(AgentRuntimeConfig(cwd=workspace))
|
||||
goal_result = execute_tool(
|
||||
default_tool_registry(),
|
||||
'data_agent_prepare_generation_goal',
|
||||
{
|
||||
'dataset_label': '地图和生活边界数据',
|
||||
'goal_summary': '生成附近生活服务边界数据',
|
||||
'target': 'Agent(tag="life_service")',
|
||||
'coverage': '附近吃喝玩乐',
|
||||
'exclusions': '不要生成导航路线类 query',
|
||||
'source_refs': ['manual:user'],
|
||||
},
|
||||
context,
|
||||
)
|
||||
self.assertTrue(goal_result.ok, goal_result.content)
|
||||
goal_id = json.loads(goal_result.content)['goal']['goal_id']
|
||||
confirm_result = execute_tool(
|
||||
default_tool_registry(),
|
||||
'data_agent_confirm_generation_goal',
|
||||
{'goal_id': goal_id, 'confirmation': '确认目标', 'reviewed_revision': 1},
|
||||
context,
|
||||
)
|
||||
self.assertTrue(confirm_result.ok, confirm_result.content)
|
||||
responses = [
|
||||
{
|
||||
'choices': [
|
||||
{
|
||||
'message': {
|
||||
'role': 'assistant',
|
||||
'content': 'I will prepare a reviewable generation plan.',
|
||||
'tool_calls': [
|
||||
{
|
||||
'id': 'call_1',
|
||||
'type': 'function',
|
||||
'function': {
|
||||
'name': 'data_agent_prepare_generation_plan',
|
||||
'arguments': json.dumps(
|
||||
{
|
||||
'confirmed_goal_id': goal_id,
|
||||
'dataset_label': '地图和生活边界数据',
|
||||
'target': 'Agent(tag="life_service")',
|
||||
'total_count': 10,
|
||||
'turn_mix': '10 条单轮',
|
||||
'coverage': '附近吃喝玩乐',
|
||||
'exclusions': '不要生成导航路线类 query',
|
||||
'output_path': 'tasks/demo/records.jsonl',
|
||||
}
|
||||
),
|
||||
},
|
||||
}
|
||||
],
|
||||
},
|
||||
'finish_reason': 'tool_calls',
|
||||
}
|
||||
]
|
||||
}
|
||||
]
|
||||
with patch('src.openai_compat.request.urlopen', side_effect=make_urlopen_side_effect(responses)):
|
||||
agent = LocalCodingAgent(
|
||||
model_config=ModelConfig(
|
||||
model='Qwen/Qwen3-Coder-30B-A3B-Instruct',
|
||||
base_url='http://127.0.0.1:8000/v1',
|
||||
),
|
||||
runtime_config=AgentRuntimeConfig(cwd=workspace),
|
||||
)
|
||||
result = agent.run('Prepare data generation plan')
|
||||
|
||||
self.assertEqual(result.stop_reason, 'user_review_required')
|
||||
self.assertIn('数据生成计划', result.final_output)
|
||||
self.assertIn('plan_id', result.final_output)
|
||||
review_messages = [
|
||||
entry
|
||||
for entry in result.transcript
|
||||
if entry.get('role') == 'assistant'
|
||||
and entry.get('stop_reason') == 'user_review_required'
|
||||
]
|
||||
self.assertEqual(len(review_messages), 1)
|
||||
self.assertIn('数据生成计划', str(review_messages[0].get('content', '')))
|
||||
|
||||
def test_write_tool_is_blocked_without_permission(self) -> None:
|
||||
with tempfile.TemporaryDirectory() as tmp_dir:
|
||||
|
||||
Reference in New Issue
Block a user