Fix ask-user review pause in web runs

This commit is contained in:
wuyang6
2026-05-13 11:11:40 +08:00
parent b0579a1247
commit 8a93319f1b
4 changed files with 141 additions and 1 deletions
+61
View File
@@ -485,6 +485,67 @@ class AgentRuntimeTests(unittest.TestCase):
self.assertEqual(len(review_messages), 1)
self.assertIn('生成参数', str(review_messages[0].get('content', '')))
def test_agent_stops_after_ask_user_question_requires_review(self) -> None:
responses = [
{
'choices': [
{
'message': {
'role': 'assistant',
'content': 'I need the user to choose a strategy.',
'tool_calls': [
{
'id': 'call_1',
'type': 'function',
'function': {
'name': 'ask_user_question',
'arguments': json.dumps(
{
'question': '选择线上挖掘策略?',
'choices': ['先宽召回', '先精确过滤'],
'allow_free_text': True,
}
),
},
}
],
},
'finish_reason': 'tool_calls',
}
]
}
]
with tempfile.TemporaryDirectory() as tmp_dir:
workspace = Path(tmp_dir)
with patch('src.openai_compat.request.urlopen', side_effect=make_urlopen_side_effect(responses)):
agent = LocalCodingAgent(
model_config=ModelConfig(
model='Qwen/Qwen3-Coder-30B-A3B-Instruct',
base_url='http://127.0.0.1:8000/v1',
),
runtime_config=AgentRuntimeConfig(cwd=workspace),
)
result = agent.run('Ask before mining')
self.assertEqual(result.stop_reason, 'user_review_required')
self.assertEqual(result.tool_calls, 1)
self.assertIn('选择线上挖掘策略', result.final_output)
self.assertIn('先宽召回', result.final_output)
review_messages = [
entry
for entry in result.transcript
if entry.get('role') == 'assistant'
and entry.get('stop_reason') == 'user_review_required'
]
self.assertEqual(len(review_messages), 1)
self.assertTrue(
any(
event.get('type') == 'user_review_required'
and event.get('tool_name') == 'ask_user_question'
for event in result.events
)
)
def test_write_tool_is_blocked_without_permission(self) -> None:
with tempfile.TemporaryDirectory() as tmp_dir:
config = AgentRuntimeConfig(cwd=Path(tmp_dir))
+25
View File
@@ -53,3 +53,28 @@ class AskUserRuntimeTests(unittest.TestCase):
self.assertIn('# Ask User', result.content)
self.assertIn('safe', result.content)
self.assertEqual(result.metadata.get('action'), 'ask_user_question')
def test_ask_user_tool_requests_web_review_when_no_answer_is_queued(self) -> None:
with tempfile.TemporaryDirectory() as tmp_dir:
workspace = Path(tmp_dir)
runtime = AskUserRuntime.from_workspace(workspace)
context = build_tool_context(
AgentRuntimeConfig(cwd=workspace),
ask_user_runtime=runtime,
)
result = execute_tool(
default_tool_registry(),
'ask_user_question',
{
'question': 'Choose mining strategy',
'choices': ['fast sample', 'strict filter'],
'allow_free_text': True,
},
context,
)
self.assertTrue(result.ok)
self.assertEqual(result.metadata.get('action'), 'ask_user_question')
self.assertTrue(result.metadata.get('requires_user_review'))
self.assertIn('Choose mining strategy', result.content)
self.assertIn('fast sample', result.content)